fix: resolve open Dependabot and code-scanning alerts - #74
Merged
Conversation
- bump transitive dev dependency js-yaml to 3.15.1 (GHSA-5p4m-2wfm-xmqj, GHSA-52cp-r559-cp3m, GHSA-h67p-54hq-rp68); lockfile-only change within the ^3.13.1 range required by @istanbuljs/load-nyc-config - add least-privilege GITHUB_TOKEN permissions (contents: read) to the PR workflow (actions/missing-workflow-permissions) Signed-off-by: kurok <22548029+kurok@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One PR resolving all open Dependabot alerts and the fixable code-scanning alerts.
Dependabot alerts #1, #4, #12 — js-yaml 3.x DoS (high/medium)
Bumps transitive dev dependency
js-yaml3.14.2 → 3.15.1 (GHSA-5p4m-2wfm-xmqj, GHSA-52cp-r559-cp3m, GHSA-h67p-54hq-rp68). Lockfile-only:@istanbuljs/load-nyc-configrequires^3.13.1, which 3.15.1 satisfies. Dev-only, sodist/is unaffected.Code-scanning alerts #1–#4 — actions/missing-workflow-permissions (medium)
Adds a workflow-level
permissions: contents: readblock to.github/workflows/pr.yml, covering all four jobs. No job needs write access (the runner-checksum job only reads a public release).Code-scanning alert #5 — js/incomplete-sanitization in dist/index.js (high)
Not addressed here: the flagged
quoteHeaderfunction is bundled AWS SDK (smithy) vendor code inside the generateddist/index.js, not this repo's source. Dismissed on the alert with an explanatory comment.Verification
npm ci— clean install, 0 vulnerabilitiesnpm test— 245 passingnpm run package— rebuiltdist/is byte-identical (dev-only dep change)